Skip to content

CI runner#2

Merged
lukaskollmer merged 1 commit into
mainfrom
lukas/runners
Jun 25, 2026
Merged

CI runner#2
lukaskollmer merged 1 commit into
mainfrom
lukas/runners

Conversation

@lukaskollmer

@lukaskollmer lukaskollmer commented Jun 25, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

CI runner

♻️ Current situation & Problem

issue: we currently hardcode ubuntu for the linux CI, which isn't necessary anymore

⚙️ Release Notes

n/a

📚 Documentation

n/a

✅ Testing

n/a

Code of Conduct & Contributing Guidelines

By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.

Summary by CodeRabbit

  • Chores
    • Updated the project’s automated build workflow to use the default runner selection.
    • Allowed the shared workflow to access repository secrets, improving compatibility with the CI setup.

@lukaskollmer lukaskollmer self-assigned this Jun 25, 2026
@coderabbitai

coderabbitai Bot commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b095a022-277a-4d17-a3f3-3027b9bc17f2

📥 Commits

Reviewing files that changed from the base of the PR and between 7295e0c and 5f92d49.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/ci.yml
📝 Walkthrough

Walkthrough

The CI job now invokes the reusable Swift package workflow without an explicit Linux runner list and with inherited secrets. The job-level permission settings remain in place.

Changes

Reusable CI workflow invocation

Layer / File(s) Summary
Workflow call inputs
.github/workflows/ci.yml		 The ci job removes the linux_runners input and adds secrets: inherit on the reusable workflow call.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

enhancement

Suggested reviewers

  • PSchmiedmayer
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is too generic and doesn’t clearly describe the CI workflow change or the removed Ubuntu runner hardcoding. Rename it to something specific like 'Remove hardcoded Ubuntu runner from CI workflow'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch lukas/runners

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@lukaskollmer lukaskollmer merged commit 784f58e into main Jun 25, 2026
41 of 44 checks passed
@lukaskollmer lukaskollmer deleted the lukas/runners branch June 25, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PSchmiedmayer PSchmiedmayer PSchmiedmayer approved these changes

Assignees

@lukaskollmer lukaskollmer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lukaskollmer @PSchmiedmayer